feat: processor service integration #22
Conversation
apps/processor/README.md
Outdated
|
|
||
| ### ⚙️ Setting up env variables | ||
|
|
||
| - Create `.env` file and copy paste `.env.example` content in there. |
There was a problem hiding this comment.
I would add: "or run the below command"
| @@ -26,8 +21,8 @@ export class IpfsProvider implements IMetadataProvider { | |||
| ipfsCid: string, | |||
| validateContent?: z.ZodSchema<T>, | |||
| ): Promise<T | undefined> { | |||
| if (!isValidCid(ipfsCid)) { | |||
| throw new InvalidCidException(ipfsCid); | |||
| if (ipfsCid === "" || !isValidCid(ipfsCid)) { | |||
There was a problem hiding this comment.
logging might be good here if just returning undefined
There was a problem hiding this comment.
could be, i think here i'll leave the responsibility of logging to the caller
apps/processor/README.md
Outdated
| | `DATABASE_URL` | PostgreSQL Data Layer database connection URL | N/A | Yes | | | ||
| | `DATABASE_SCHEMA` | PostgreSQL Data Layer database schema name | chainDataSchema | Yes | | | ||
| | `INDEXER_GRAPHQL_URL` | GraphQL endpoint for the indexer | N/A | Yes | | | ||
| | `INDEXER_ADMIN_SECRET` | Admin secret for indexer authentication | N/A | Yes | | |
There was a problem hiding this comment.
we should change this, admin secret is just for admins, should be a way to generate some token for client auth
There was a problem hiding this comment.
apps/processor/README.md
Outdated
| | `INDEXER_ADMIN_SECRET` | Admin secret for indexer authentication | N/A | Yes | | | ||
| | `IPFS_GATEWAYS_URL` | Array of IPFS gateway URLs | N/A | Yes | Multiple gateways for redundancy | | ||
| | `COINGECKO_API_KEY` | API key for CoinGecko service | N/A | Yes | | | ||
| | `COINGECKO_API_TYPE` | CoinGecko API tier (demo or pro) | N/A | Yes | | |
There was a problem hiding this comment.
give me my Pro Key xd
apps/processor/src/index.ts
Outdated
| let processor: ProcessorService; | ||
|
|
||
| const main = async (): Promise<void> => { | ||
| processor = new ProcessorService(environment); |
There was a problem hiding this comment.
What about using Processing instead of Processor to avoid confusion with the event processors, if we modify this we should include modifying file names also
There was a problem hiding this comment.
aaa okay makes sense, Processor was a more natural naming. the app folder should also be apps/processing?
🤖 Linear
Closes GIT-74 GIT-75
Description
processorapp that integrates all the Core components of the processing pipeline and runs a single chain OrchestratorenvioversionChecklist before requesting a review